Fix printing of array types in JSpecify errors #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1145 +/- ##
=========================================
Coverage 88.22% 88.23%
- Complexity 2260 2261 +1
=========================================
Files 85 85
Lines 7312 7318 +6
Branches 1461 1462 +1
=========================================
+ Hits 6451 6457 +6
Misses 432 432
Partials 429 429 ☔ View full report in Codecov by Sentry. |
| @@ -596,7 +595,7 @@ public void varargsOverride() { | |||
| " }", | |||
| " static class NullableVarargsBothImpl3 implements NullableVarargsBoth {", | |||
| " @Override", | |||
| " // BUG: Diagnostic contains: Parameter has type Object[]", | |||
| " // BUG: Diagnostic contains: Parameter has type Object @Nullable []", | |||
There was a problem hiding this comment.
Does the diagnostic say "Object @nullable []" now instead of "Object []" because the default behavior is that un-annotated parameters are nullable?
There was a problem hiding this comment.
No, we just weren't printing the type properly at all before. If we have a varargs parameter Object @Nullable... params, the type of the params array is Object @Nullable []. We're just fixing a serious bug in printing types in error messages.
akshayutture
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we would not print nullability of the top-level array type. Also improve spacing.